Skip to content

Add mass fraction multi-phase table to sesame2spiner#600

Draft
adamdempsey90 wants to merge 3 commits intomainfrom
dempsey/mass_frac
Draft

Add mass fraction multi-phase table to sesame2spiner#600
adamdempsey90 wants to merge 3 commits intomainfrom
dempsey/mass_frac

Conversation

@adamdempsey90
Copy link
Collaborator

@adamdempsey90 adamdempsey90 commented Jan 12, 2026

PR Summary

This adds the mass fraction SESAME table to the spiner tables that sesame2spiner outputs (if it exists). Tested in a downstream code.

Putting this up now for an initial review.

I still need to add the mass fractions to the spiner EOS class. Are we okay with adding new MassFractionFromDensityTemperature functions to all EOS classes?

Still TODO:

  • Add this field to the spiner EOS
  • Some sort of test

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@adamdempsey90 adamdempsey90 self-assigned this Jan 12, 2026
@adamdempsey90 adamdempsey90 marked this pull request as draft January 12, 2026 20:41
jhp-lanl
jhp-lanl reviewed Jan 12, 2026
View reviewed changes
Yurlungur
Yurlungur reviewed Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad it was a simple change. Regarding adding mass fractions to every EOS class... Broadly I'd be supportive of this, if we had an error message/stub in the base class as the default behavior. Clearly mass fractions aren't sensible for all EOS's but they are for enough EOS's we might want this.

@adamdempsey90
Copy link
Collaborator Author

adamdempsey90 commented Jan 12, 2026

Nice! Glad it was a simple change. Regarding adding mass fractions to every EOS class... Broadly I'd be supportive of this, if we had an error message/stub in the base class as the default behavior. Clearly mass fractions aren't sensible for all EOS's but they are for enough EOS's we might want this.

It looks like the StellarCollapse EOS already has MassFractionsFromDensityTemperature

@Yurlungur
Copy link
Collaborator

Yurlungur commented Jan 12, 2026

Nice! Glad it was a simple change. Regarding adding mass fractions to every EOS class... Broadly I'd be supportive of this, if we had an error message/stub in the base class as the default behavior. Clearly mass fractions aren't sensible for all EOS's but they are for enough EOS's we might want this.

It looks like the StellarCollapse EOS already has MassFractionsFromDensityTemperature

I believe Helmholtz does too... or if it doesn't, it could be exposed.

@adamdempsey90
Add table existence check to eospac_wrapper. Return a bool from eosMa…
909776e 
…ssFraction and fill the string rather than the other way around
@adamdempsey90
Move getting of phase names and number of phases to eospac_wrapper an…
a8a9804 
…d use the generic functions to do it
adamdempsey90
adamdempsey90 commented Jan 15, 2026
View reviewed changes
sesame2spiner/io_eospac.cpp
Comment on lines +354 to +356
std::vector<EOS_REAL> rhos, Ts, phs;
makeInterpPoints(rhos, lRhoBounds);
makeInterpPoints(Ts, lTBounds);
Copy link
Collaborator Author

@adamdempsey90 adamdempsey90 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am re-using the EOS rho-T grid for this but in testing we are seeing that maybe that isn't great, e.g., instead of clustering around STP, we probably want to cluster the points around phase transitions. I could add another set of parameters to the inputs that describe the grid decomp for just mass fractions?

Copy link
Collaborator

@Yurlungur Yurlungur Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes a lot of sense. Yeah there's no reason the two grids have to be the same.

Copy link
Collaborator

@buechlerm buechlerm Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to use different grids, I would just use the sesame grid. (piecewise linear). eospac just does bilinear interpolation for mass fractions so we should not need higher density than sesame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yurlungur Yurlungur Yurlungur left review comments

@jhp-lanl jhp-lanl jhp-lanl left review comments

@buechlerm buechlerm Awaiting requested review from buechlerm

At least 1 approving review is required to merge this pull request.

Assignees

@adamdempsey90 adamdempsey90

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adamdempsey90 @Yurlungur @jhp-lanl @buechlerm